sganggs 3288afc787 feedback5: merge R6 (tooling) — correctness-only ESLint, a first checkJs slice + core typedefs, tools/check-imports.mjs, tools/package.mjs (+ --lite), CI tooling job

2026-10-05 16:34:01 +08:00

..

content

feedback5 R4: kits/README.md — how a kit file is built, what it may use (shared helpers, the battle API of docs/SIM.md), naming, registration, tests, the fidelity rule and a ten-item fidelity checklist per operator with example kits and tests (for the stand-ins, self-select 6★ operators and GitHub #136); test/content/kits_layout.test.js checks that every ops/ file is listed in kits/index.js, named after its chess id and charId, registers exactly its kit, and imports nothing Node-only or server-only and no clock / Math.random

2026-10-05 16:26:29 +08:00

e2e

feedback4: the real-browser e2e suites confirm the leftover-funds prompt on the Space path too (coop.e2e 4/4, real.e2e 2/2)

2026-10-05 14:28:47 +08:00

fixtures

feedback1 WB: bounty drafts and the 机密商店 from 66 official screenshots (22 matches)

2026-10-03 07:42:20 +08:00

golden

feedback5 WA: golden-result safety net before the 0.2.0 refactor — tools/golden.mjs runs a seeded corpus (49 roster battles: every chess record × skill × module, every stage and enemy kind; 46 bond battles; 22 leader / 联防 fields; 16 bot-only matches) and test/golden.test.js compares its digests with test/golden/*.json field by field (fast subset by default, GOLDEN_FULL=1 for all; npm run golden / golden:update; test/golden/README.md)

2026-10-05 15:49:24 +08:00

helpers

feedback5 R4: paths after the kit split — DESIGN §7 and SIM.md (layout, §7.2 kit contract, kit citations), research 09, code comments (content/generic, tokens, items/battle, shared/loadoutRecord, render fx / demo), test comments, and the kits' own comments that named tierN.js; DESIGN §17–§23 history citations are left as they are

2026-10-05 16:18:58 +08:00

match

feedback3: merge WJ — 高台 only for elite 歌蕾蒂娅 with HOK-Y, live prep watch, silenced 折射, grant toasts, emote timeout glyph

2026-10-04 21:26:46 +08:00

render

feedback5 R4: paths after the kit split — DESIGN §7 and SIM.md (layout, §7.2 kit contract, kit citations), research 09, code comments (content/generic, tokens, items/battle, shared/loadoutRecord, render fx / demo), test comments, and the kits' own comments that named tierN.js; DESIGN §17–§23 history citations are left as they are

2026-10-05 16:18:58 +08:00

sim

feedback5 R4: paths after the kit split — DESIGN §7 and SIM.md (layout, §7.2 kit contract, kit citations), research 09, code comments (content/generic, tokens, items/battle, shared/loadoutRecord, render fx / demo), test comments, and the kits' own comments that named tierN.js; DESIGN §17–§23 history citations are left as they are

2026-10-05 16:18:58 +08:00

ui

feedback5 R1: docs and comments follow the split — DESIGN §2 layout lists server/http/, the README table names the entry and http/, path comments in shared/media.js, public/js/media.js, buildGuard.js, net.js and three tests point at the new modules; .git-blame-ignore-revs lists the pure-move commit

2026-10-05 16:11:30 +08:00

assets.test.js

feedback2 WE: setup downloads the 36 battle emotes and the 19 玩法说明 pages from the public mirror (ArknightsAssets2 cn); the client shows the local-client art first, then the mirror copy, then its fallback (#42)

2026-10-03 23:05:42 +08:00

backups.test.js

feedback5 WB: the data of 补位 and 自选 — chess.json keeps the official backup fields, data/backups.json builds the 17 stand-ins and the DIY picks

2026-10-05 15:58:10 +08:00

build.test.js

feedback5 R1: docs and comments follow the split — DESIGN §2 layout lists server/http/, the README table names the entry and http/, path comments in shared/media.js, public/js/media.js, buildGuard.js, net.js and three tests point at the new modules; .git-blame-ignore-revs lists the pure-move commit

2026-10-05 16:11:30 +08:00

check-imports.test.js

feedback5 R6: check that sim and match stay off the net and the client

2026-10-05 16:20:55 +08:00

client-static.test.js

feedback5 R1: docs and comments follow the split — DESIGN §2 layout lists server/http/, the README table names the entry and http/, path comments in shared/media.js, public/js/media.js, buildGuard.js, net.js and three tests point at the new modules; .git-blame-ignore-revs lists the pure-move commit

2026-10-05 16:11:30 +08:00

data.test.js

feedback5 WB: the data of 补位 and 自选 — chess.json keeps the official backup fields, data/backups.json builds the 17 stand-ins and the DIY picks

2026-10-05 15:58:10 +08:00

docs-consistency.test.js

feedback5: merge R4 — operator kits one file per chess (kits/ops/*, kits/shared/*, kits/index.js in the old registry order) + kits/README.md with the fidelity checklist; golden unchanged

2026-10-05 16:30:29 +08:00

doctor.test.js

启动器「发给朋友」不再把代理 TUN 当公网 IP；删掉永不生效的 ^tun\d

2026-10-03 15:41:57 +08:00

feedback1d-models.test.js

feedback1d WN: the web alias of 灼热/炽焰源石虫 is drawn tinted toward their own colours; bundle step documented

2026-10-03 05:55:29 +08:00

fetch-assets-shrink.test.js

feedback2 WE: setup downloads the 36 battle emotes and the 19 玩法说明 pages from the public mirror (ArknightsAssets2 cn); the client shows the local-client art first, then the mirror copy, then its fallback (#42)

2026-10-03 23:05:42 +08:00

golden.test.js

feedback5 WA: golden-result safety net before the 0.2.0 refactor — tools/golden.mjs runs a seeded corpus (49 roster battles: every chess record × skill × module, every stage and enemy kind; 46 bond battles; 22 leader / 联防 fields; 16 bot-only matches) and test/golden.test.js compares its digests with test/golden/*.json field by field (fast subset by default, GOLDEN_FULL=1 for all; npm run golden / golden:update; test/golden/README.md)

2026-10-05 15:49:24 +08:00

lobby-kick.test.js

feedback3 W3C: room.kick names the confirmed player; a seat that changed hands while the host confirmed is refused (BAD_TARGET)

2026-10-04 17:38:29 +08:00

lobby-loadout.test.js

卫戍协议：盟约 web remake — initial import

2026-09-29 16:21:31 +08:00

lobby.test.js

feedback3 WE: spectator seats in the browser — 观战 in the lobby, the 观战席 strip in the room (host removes, 入座), watch-only match screen; docs (community report #26)

2026-10-04 17:39:30 +08:00

local-extract.test.js

Playtest #6 fixes: summons placed by hand, boss pool stall, bounties, 联防 leak counter, distinct offers, 机变 card text, phone buy tap, skill triggers, blocking, push force, 孤立, enemies, element bar

2026-10-01 19:08:23 +08:00

media-url.test.js

按 review 意见：/media/ 的路径与扩展名列表提到 shared/ 共用

2026-10-03 22:33:20 +08:00

open-browser.test.js

打开浏览器改用 explorer.exe（shell 关联），找不到时才用 rundll32 (#29)

2026-10-03 23:05:06 +08:00

package.test.js

feedback5 R6: add a player package tool with a lite dry-run

2026-10-05 16:23:47 +08:00

static-local-art.test.js

feedback2 WE: review wording — ASSETS.md and DESIGN §13 say the HUD sprites are not downloaded (most are on the mirror), §22.5 says the mirror copies match the local sizes and that #38 stays open; setup's no-client row only points to DEPLOY §6 (doctor keeps the copy hint); stale test messages

2026-10-03 23:51:11 +08:00

version.test.js

feedback5 R1: startServer and main become wiring — PORT / HOST / TRUST_PROXY and the option picks go to http/config.js, the session stack and the /ws upgrade to http/websocket.js, the request listener and /healthz to http/routes.js (new), the security headers and the clientError 400 to http/common.js, the banner, signals and entry check to http/boot.js

2026-10-05 16:08:41 +08:00

windows-bundle.test.js

Windows 便携包：只收 git 跟踪的文件、生产依赖、钉死的 Node 版本与许可证 (#30)

2026-10-04 14:20:11 +08:00