Files
ark-stronghold-protocol/test/lobby-ai-last.test.js
T
anAtheist987 fd791a66cb feedback7 G-SMALL: co-op rooms can make AI teammates draft last (PR #368 by @anAtheist987)
Applied the host-only room option 「AI 队友最后选择」, default off. Off, the draft order and the random streams stay as they are. On, humans draft before AI seats after the existing shuffle, and a skip stays ahead of the AI seats.

Dropped docs/history/0.2.2.md and every §27 citation. The player-facing sentence is in docs/PLAYING.md. The room-option rule is in docs/design/match.md, docs/design/client.md and docs/design/network.md. The #338 per-bot faction and ban presets are not included.

Tests: node --test test/lobby-ai-last.test.js test/match/ai-picks-last.test.js test/ui/ai-picks-last.test.js — 18 pass. node --test test/lobby.test.js test/client-static.test.js — 378 pass. node tools/i18n.mjs check --all --strict — 1032/1032 in en, ja, ko and zh-TW, 0 errors.
2026-10-08 19:57:26 +08:00

146 lines
6.7 KiB
JavaScript

// test/lobby-ai-last.test.js — the co-op room option 「AI 队友最后选择」 (room.setAiPicksLast {on}; GitHub #338): host-only,
// before the match only, co-op rooms only, off by default; room.state.aiPicksLast shows it to everybody; the match gets
// it as opts.aiPicksLast when it starts (server/match/Match.js orders the drafts with it — test/match/ai-picks-last.test.js).
import { describe, test, before, after, afterEach } from 'node:test';
import assert from 'node:assert/strict';
import { startServer } from '../server/index.js';
import { StubMatch } from '../server/match/StubMatch.js';
import { TestClient } from './helpers/wsClient.js';
import { ERR } from '../shared/constants.js';
import { validateC2S } from '../shared/protocol.js';
function clientPool(getUrl) {
const open = new Set();
return {
async connect() { const c = await TestClient.connect(getUrl()); open.add(c); return c; },
async player(name, token) {
const c = await this.connect();
const w = await c.hello(name, token);
c.id = w.playerId;
c.token = w.token;
return c;
},
async closeAll() {
await Promise.all([...open].map((c) => c.terminate().catch(() => {})));
open.clear();
},
};
}
const quietLog = () => {
const errors = [];
return { errors, log: { info() {}, warn() {}, debug() {}, error: (...a) => errors.push(a.map(String).join(' ')) } };
};
const ok = async (c, msg) => { const r = await c.request(msg); assert.equal(r.t, 'ok', `${msg.t}: ${JSON.stringify(r)}`); return r; };
const err = async (c, msg, code) => { const r = await c.request(msg); assert.equal(r.t, 'error', JSON.stringify(r)); assert.equal(r.code, code, JSON.stringify(r)); return r; };
const seatOf = (state, id) => state.seats.find((s) => s && s.playerId === id) || null;
async function createRoom(c, mode = 'coop') {
await ok(c, { t: 'room.create', mode, difficulty: 'NORMAL' });
return c.waitFor('room.state', (s) => s.hostId === c.id && s.mode === mode);
}
async function joinRoom(c, code) {
await ok(c, { t: 'room.join', code });
return c.waitFor('room.state', (s) => s.code === code && !!seatOf(s, c.id));
}
/** StubMatch that records the options each match was started with. */
const started = [];
class RecordingMatch extends StubMatch {
constructor(opts) {
super(opts);
started.push(opts);
}
}
test('protocol: room.setAiPicksLast takes exactly a boolean `on`', () => {
assert.equal(validateC2S({ t: 'room.setAiPicksLast', on: true }), null);
assert.equal(validateC2S({ t: 'room.setAiPicksLast', on: false }), null);
for (const on of [undefined, null, 1, 0, 'true', 'yes', {}, []]) {
assert.notEqual(validateC2S({ t: 'room.setAiPicksLast', on }), null, JSON.stringify(on));
}
});
describe('room.setAiPicksLast (lobby)', () => {
let srv;
let pool;
const cap = quietLog();
before(async () => {
srv = await startServer({ port: 0, host: '127.0.0.1', log: cap.log, MatchClass: RecordingMatch, lobbyGraceMs: 60_000 });
pool = clientPool(() => `ws://127.0.0.1:${srv.port}/ws`);
});
afterEach(async () => { await pool.closeAll(); });
after(async () => {
await srv?.close();
assert.deepEqual(cap.errors, [], 'no server errors logged');
});
test('off by default; host-only; every seat sees it in room.state; a change un-readies the guests like the difficulty', async () => {
const host = await pool.player('Host');
const st = await createRoom(host);
assert.equal(st.aiPicksLast, false);
const guest = await pool.player('Guest');
const js = await joinRoom(guest, st.code);
assert.equal(js.aiPicksLast, false);
await err(guest, { t: 'room.setAiPicksLast', on: true }, ERR.NOT_HOST);
await ok(guest, { t: 'room.ready', ready: true });
await host.waitFor('room.state', (s) => seatOf(s, guest.id)?.ready);
await ok(host, { t: 'room.setAiPicksLast', on: true });
const on = await guest.waitFor('room.state', (s) => s.aiPicksLast === true);
assert.equal(seatOf(on, guest.id).ready, false, 'the rules changed: the guest confirms again');
await host.waitFor('room.state', (s) => s.aiPicksLast === true);
// the same value again changes nothing (no broadcast needed, still ok)
await ok(host, { t: 'room.setAiPicksLast', on: true });
await ok(host, { t: 'room.setAiPicksLast', on: false });
await guest.waitFor('room.state', (s) => s.aiPicksLast === false);
// a malformed value never reaches the lobby
await err(host, { t: 'room.setAiPicksLast', on: 'yes' }, ERR.BAD_MSG);
});
test('solo rooms have no AI teammates: refused, the state stays off', async () => {
const host = await pool.player('Solo');
const st = await createRoom(host, 'solo');
assert.equal(st.aiPicksLast, false);
await err(host, { t: 'room.setAiPicksLast', on: true }, ERR.BAD_TARGET);
});
test('the match gets it at the start; it cannot change during the match; the room keeps it for the next match and a new host', async () => {
const host = await pool.player('Host');
const st = await createRoom(host);
const guest = await pool.player('Guest');
await joinRoom(guest, st.code);
await ok(host, { t: 'room.addBot' });
await ok(host, { t: 'room.setAiPicksLast', on: true });
await ok(guest, { t: 'room.ready', ready: true });
await host.waitFor('room.state', (s) => s.aiPicksLast && seatOf(s, guest.id)?.ready);
const n = started.length;
await ok(host, { t: 'room.start' });
await guest.waitFor('room.state', (s) => s.inMatch && s.aiPicksLast === true);
assert.equal(started.length, n + 1);
assert.equal(started[n].aiPicksLast, true, 'opts.aiPicksLast');
await err(host, { t: 'room.setAiPicksLast', on: false }, ERR.ROOM_STARTED);
await err(guest, { t: 'room.setAiPicksLast', on: false }, ERR.NOT_HOST);
// the stub match ends once every human confirmed the briefing → back in the lobby with the option kept
guest.clearInbox();
await ok(host, { t: 'g.infoReady' });
await ok(guest, { t: 'g.infoReady' });
const back = await guest.waitFor('room.state', (s) => !s.inMatch);
assert.equal(back.aiPicksLast, true);
// host migration keeps the room's settings
await ok(host, { t: 'room.leave' });
const migrated = await guest.waitFor('room.state', (s) => s.hostId === guest.id);
assert.equal(migrated.aiPicksLast, true);
await ok(guest, { t: 'room.setAiPicksLast', on: false });
await guest.waitFor('room.state', (s) => s.aiPicksLast === false);
});
test('without the option the match gets aiPicksLast false', async () => {
const host = await pool.player('Host');
await createRoom(host);
await ok(host, { t: 'room.addBot' });
const n = started.length;
await ok(host, { t: 'room.start' });
await host.waitFor('room.state', (s) => s.inMatch);
assert.equal(started[n].aiPicksLast, false);
});
});