feedback2 WI: a running 坚固维式重锤 不死 window stops a dollkeeper's switch to its 替身 (fatal priority −99, the lock stays at −100); the switch flag is trait.dollSwitching; the 替身's own max HP is stated as sourced (review of #44)

test/sim/feedback2-doll.test.js

@@ -9,6 +9,7 @@ import { test } from 'node:test';
 import assert from 'node:assert/strict';
 import { makeBattle, enemyRec, checkInvariants } from '../helpers/battleHarness.js';
 import { DOLL_SWITCH } from '../../server/sim/professions.js';
+import { holdsUndying } from '../../server/sim/content/items/battle.js';
 import { hasGeneratedData } from '../../server/sim/simdata.js';
 import { fxForm } from '../../shared/protocol.js';
 
@@ -18,11 +19,11 @@ const approx = (a, b, msg, eps = 1e-6) => assert.ok(Math.abs(a - b) <= eps, `${m
 const dummy = () => enemyRec({ key: 'enemy_dummy', hp: 1e9, atk: 0, speed: 0 });
 
 /** 归溟幽灵鲨 on (9,5) facing right; a harmless parked enemy on (9,6) (in her range) unless `enemy` is false. */
-function setup({ id = G, skillIndex = 1, sp = 0, enemy = true, capture = false } = {}) {
+function setup({ id = G, skillIndex = 1, sp = 0, enemy = true, capture = false, items = undefined } = {}) {
   const h = makeBattle({
     seed: 4, timeLimit: 300, autoFinish: false, captureNoisy: capture,
     defs: { enemies: { enemy_dummy: dummy() } },
-    units: [{ chessId: id, row: 9, col: 5, dir: 'RIGHT', skillIndex, carryState: { sp } }],
+    units: [{ chessId: id, row: 9, col: 5, dir: 'RIGHT', skillIndex, carryState: { sp }, items }],
     enemies: enemy ? [{ key: 'enemy_dummy', pos: [9, 6] }] : [],
   });
   h.step();
@@ -46,7 +47,7 @@ test('A: a lethal hit with no skill running ⇒ the 替身 (form, full HP, block
     lethal();
     assert.ok(g.alive && g.trait.doll && g.form === 'doll', `${id}/${skillIndex}: the 替身`);
     approx(g.hp, g.s.maxHp, 'full HP');
-    approx(g.s.maxHp, full * (1 + (g.def.traitBb.max_hp || 0)), 'her own max HP (no 替身 token) [ASSUMED]');
+    approx(g.s.maxHp, full * (1 + (g.def.traitBb.max_hp || 0)), 'her own max HP (no 替身 token; trait bb max_hp the module bonus)');
     assert.equal(g.s.blockCnt, 0);
     const [sub] = fx('substitute');
     assert.ok(sub && fxForm(sub) === 'doll', 'the fx puts the model in its 替身 form');
@@ -58,7 +59,7 @@ test('A: a lethal hit with no skill running ⇒ the 替身 (form, full HP, block
     assert.ok(e.findBuff('ghost2:embrace'), '拥抱自我 slows');
     assert.ok(h.hooksOf('damaged').some((c) => c.source === g && c.target === e && (c.dmg.tags || []).includes('embrace')), '…and deals arts damage');
     h.run(1.05);
-    assert.ok(!g.trait.doll && g.form === null && g.trait.dollSwitch, 'switching back after 1 s + 20 s');
+    assert.ok(!g.trait.doll && g.form === null && g.trait.dollSwitching, 'switching back after 1 s + 20 s');
     assert.ok(fxForm(fx('swap')[0]) === null, 'the fx gives the 本体 its model back');
     assert.equal(g.s.blockCnt, 2);
     approx(g.hp, g.s.maxHp, 'full HP again');
@@ -157,6 +158,25 @@ test('S1 / S3 running at a lethal hit end with the switch (清除自身一切Buf
   assert.equal(s2.h.b.emit('dollSwitch', { unit: s2.g, reason: 'test', done: false }).done, false, 'already the 替身');
 });
 
+test('a 本体 holding 不死 (a running 坚固维式重锤 window) does not switch: held at 1 HP (PRTS "受到足以致命的伤害且未持有不死的情况下")', { skip }, () => {
+  const { h, g, lethal } = setup({ items: ['chess_item_3_09_e_a'] });
+  lethal();
+  assert.ok(g.trait.doll && !holdsUndying(h.b, g), 'the first lethal hit: the switch, the hammer\'s lock unspent');
+  h.run(15);
+  lethal();
+  assert.ok(g.alive && g.trait.doll && holdsUndying(h.b, g), 'the 替身\'s lethal hit sets off the lock: 8 s of 不死');
+  approx(g.hp, 1, 'held at 1 HP');
+  assert.ok(h.runUntil(() => !g.trait.doll && !g.trait.dollSwitching, 10), 'switched back');
+  assert.ok(holdsUndying(h.b, g), 'the window still runs');
+  lethal();
+  assert.ok(g.alive && !g.trait.doll && g.form === null, 'no switch while it holds 不死');
+  approx(g.hp, 1, 'held at 1 HP');
+  assert.ok(h.runUntil(() => !holdsUndying(h.b, g), 10));
+  lethal();
+  assert.ok(g.alive && g.trait.doll, 'the window over: the switch');
+  checkInvariants(h.b);
+});
+
 test('风丸: her 替身 still attacks (PRTS "<替身>状态下可对空"); the same 替身 form, switch and 阻回', { skip }, () => {
   const id = 'chess_char_2_11_a';
   const { h, g, log, lethal } = setup({ id, skillIndex: 0 });

test/sim/fidelity.test.js

@@ -260,7 +260,7 @@ test('dollkeeper without a substitute token (归溟幽灵鲨) keeps its own max
   const full = u.s.maxHp;
   h.b.dealDamage(null, u, { amount: 1e7, type: 'true' });
   assert.ok(u.alive && u.hasBuff('trait:substitute'));
-  // PRTS 分支特性信息 傀儡师 "重设自身生命至最大值"; no 替身 of hers in character_table [ASSUMED: her own max HP]
+  // PRTS 分支特性信息 傀儡师 "重设自身生命至最大值"; the trait's 替身 HP bonus (bb max_hp) is 0 and 风丸's 纸偶 has her own HP
   approx(u.s.maxHp, full, 1e-6);
   approx(u.hp, full, 1e-6);
 });

test/sim/professions.test.js

@@ -166,7 +166,7 @@ test('dollkeeper: fatal damage ⇒ a 1 s switch, 20 s as the substitute (block 0
   h.b.dealDamage(null, u, { amount: 1e5, type: 'true' });
   assert.equal(u.alive, true, 'substitute instead of death');
   assert.equal(u.s.blockCnt, 0);
-  assert.ok(u.trait.doll && u.trait.dollSwitch, 'the switch animation');
+  assert.ok(u.trait.doll && u.trait.dollSwitching, 'the switch animation');
   assert.equal(u.form, 'doll');
   approx(u.hp, 2000); // no 替身 token: its own max HP
   // the switch animation (PRTS 分支特性信息 傀儡师): 无敌, 不死 (a 流失 stops at 1 HP), 阻回, 眩晕 immunity
@@ -177,15 +177,15 @@ test('dollkeeper: fatal damage ⇒ a 1 s switch, 20 s as the substitute (block 0
   assert.ok(u.alive && u.trait.doll && u.hp >= 1, '不死');
   u.hp = 2000;
   h.run(1.05);
-  assert.ok(u.trait.doll && !u.trait.dollSwitch, 'fighting as the substitute');
+  assert.ok(u.trait.doll && !u.trait.dollSwitching, 'fighting as the substitute');
   h.run(19.9);
   assert.ok(u.trait.doll && u.s.flags.noSp, 'the 20 s form, 阻回');
   h.run(0.1);
-  assert.ok(!u.trait.doll && u.trait.dollSwitch && u.form === null, 'switching back');
+  assert.ok(!u.trait.doll && u.trait.dollSwitching && u.form === null, 'switching back');
   assert.equal(u.s.blockCnt, 2, 'blocks again from the start of the switch back');
   approx(u.hp, 2000);
   h.run(1.05);
-  assert.ok(!u.trait.dollSwitch && !u.s.flags.noSp, 'the body again, no 阻回');
+  assert.ok(!u.trait.dollSwitching && !u.s.flags.noSp, 'the body again, no 阻回');
   h.b.dealDamage(null, u, { amount: 1e5, type: 'true' });
   h.run(1.05);
   h.b.dealDamage(null, u, { amount: 1e5, type: 'true' });