diff --git a/scripts/launch.mjs b/scripts/launch.mjs index ab675e11..d8f28216 100755 --- a/scripts/launch.mjs +++ b/scripts/launch.mjs @@ -16,6 +16,8 @@ import { spawn, spawnSync } from 'node:child_process'; import path from 'node:path'; import { fileURLToPath } from 'node:url'; import fs from 'node:fs'; +// 打开浏览器只有一份实现(走 shell 关联 = 默认浏览器,且不会把浏览器拉成提权) +import { openBrowser as openInBrowser } from './open-browser.mjs'; const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..'); const IS_WIN = process.platform === 'win32'; @@ -46,21 +48,7 @@ function parseArgs(argv) { } function openBrowser(url) { - try { - let cmd; let args; - if (IS_WIN) { cmd = 'rundll32'; args = ['url.dll,FileProtocolHandler', url]; } - else if (process.platform === 'darwin') { cmd = 'open'; args = [url]; } - else { - if (!process.env.DISPLAY && !process.env.WAYLAND_DISPLAY) return false; - cmd = 'xdg-open'; args = [url]; - } - const child = spawn(cmd, args, { stdio: 'ignore', detached: true, windowsHide: true }); - child.on('error', () => {}); - child.unref(); - return true; - } catch { - return false; - } + return openInBrowser(url) !== null; } function printShare(port) { @@ -132,4 +120,12 @@ async function main() { return exited; } -main().then((code) => { process.exitCode = code; }, (e) => { console.error(e?.stack || e); process.exitCode = 1; }); +// Same convention as tools/setup.mjs: the helpers above are importable, but only running this file starts anything. +// Without the guard, importing launch.mjs would fall through to main() in the background and bind a port. +function isMain() { + try { return !!process.argv[1] && fs.realpathSync(process.argv[1]) === fs.realpathSync(fileURLToPath(import.meta.url)); } catch { return false; } +} + +if (isMain()) { + main().then((code) => { process.exitCode = code; }, (e) => { console.error(e?.stack || e); process.exitCode = 1; }); +} diff --git a/scripts/open-browser.mjs b/scripts/open-browser.mjs new file mode 100644 index 00000000..59a99865 --- /dev/null +++ b/scripts/open-browser.mjs @@ -0,0 +1,101 @@ +// Opening the game page in the player's browser. +// +// Why not `rundll32 url.dll,FileProtocolHandler` (the usual one-liner): it runs *inside* the caller's token, so a +// launcher started from an elevated console starts Edge/Chrome **elevated** too — and from then on Edge greets the +// player with 「Microsoft Edge 未响应,因为现有实例正在以提升的权限运行。是否要用普通权限重启现有实例? 是/否」 +// instead of just opening the page. +// +// `explorer.exe ` avoids that because Explorer is not the process that opens the browser: a second Explorer +// invocation hands the request to the shell instance that is already running, and *that* one (started at logon, not +// elevated) resolves the URL through the default-browser association. Caveat: this hand-off is how the shell behaves +// in practice, not an interface Microsoft documents or promises — treat it as the best available trick rather than a +// supported API, and keep the rundll32 rung around for hosts where explorer.exe cannot be found. +// +// Windows therefore has a single rung, chosen synchronously from what is actually on disk: explorer.exe when it is +// there, rundll32 otherwise. There is deliberately no "try one, fall back on spawn failure" ladder: spawn() reports +// ENOENT / EACCES through the child's asynchronous `error` event, not by throwing, so a fallback wired to a thrown +// exception would never fire in practice. +// +// There is deliberately no `cmd /c start "" ` rung either: cmd re-parses everything after `/c`, so a URL holding +// an `&` (e.g. the room link `?room=ABCD&name=…`) is split at the `&` — cmd runs `start "" ` and then +// tries to run the remainder as a second command. The browser then opens a truncated address, or a stray console +// window flashes. Passing an argument array to CreateProcess avoids the shell entirely, which is why the remaining +// rungs are safe. +import fs from 'node:fs'; +import path from 'node:path'; +import { spawn } from 'node:child_process'; + +/** Does this path exist? Injectable as `exists` so the Windows rung can be tested without the host's filesystem. */ +function realExists(p) { + try { return fs.existsSync(p); } catch { return false; } +} + +/** + * Absolute path of a system executable, or null when it is not where we expect it. + * + * Built with **win32** semantics whatever the host is: the value is handed to a Windows process, and the rung is + * also inspected from tests (CI runs them on Linux, where `path.join` is posix and would emit `C:\Windows/explorer.exe` + * — a mixed-separator string that never matches a real Windows path). + * @param {NodeJS.ProcessEnv} env + * @param {string} sub subdirectory under the Windows root ('' / '.' for the root itself) + * @param {string} name + * @param {(p: string) => boolean} exists + * @returns {string | null} + */ +function systemExe(env, sub, name, exists) { + const root = env.SystemRoot || env.windir || 'C:\\Windows'; + const abs = path.win32.join(root, sub || '.', name); + return exists(abs) ? abs : null; +} + +/** + * Candidate launch commands for `url`, best first. + * + * At most one entry per platform: which rung Windows gets is decided here, synchronously, from the filesystem. + * @param {string} url + * @param {{ platform?: string, env?: NodeJS.ProcessEnv, exists?: (p: string) => boolean }} [o] + * `exists` defaults to the real filesystem; pass one in to test the Windows rung from any host. + * @returns {{ cmd: string, args: string[], label: string }[]} + */ +export function browserCommands(url, { platform = process.platform, env = process.env, exists = realExists } = {}) { + if (platform === 'win32') { + // shell association: the default browser, opened by the non-elevated shell instance (see the header) + const explorer = systemExe(env, '.', 'explorer.exe', exists); + if (explorer) return [{ cmd: explorer, args: [url], label: 'explorer' }]; + // legacy fallback for the theoretical case of a Windows host without explorer.exe; it *does* inherit our token, + // so it is only ever reached when the de-elevating rung is unavailable + const rundll32 = systemExe(env, 'System32', 'rundll32.exe', exists); + if (rundll32) return [{ cmd: rundll32, args: ['url.dll,FileProtocolHandler', url], label: 'rundll32' }]; + return []; + } + if (platform === 'darwin') return [{ cmd: 'open', args: [url], label: 'open' }]; + if (env.DISPLAY || env.WAYLAND_DISPLAY) return [{ cmd: 'xdg-open', args: [url], label: 'xdg-open' }]; + return []; +} + +/** + * Open `url` with the player's default browser. Returns the label of the launcher that was spawned, or null when + * there is nothing to start (headless Linux, no known system binary) — callers then just print the URL. + * + * The label is returned as soon as spawn() accepted the command. A missing binary surfaces later as the child's + * `error` event (ENOENT / EACCES), which is why one is attached: an unhandled `error` event would crash the + * launcher, and retrying a different rung at that point would mean opening a second browser after a race. + * @param {string} url + * @param {{ spawnImpl?: typeof spawn, platform?: string, env?: NodeJS.ProcessEnv, + * exists?: (p: string) => boolean, log?: (m: string) => void }} [o] + * @returns {string | null} + */ +export function openBrowser(url, { spawnImpl = spawn, platform = process.platform, env = process.env, exists = realExists, log } = {}) { + for (const { cmd, args, label } of browserCommands(url, { platform, env, exists })) { + try { + const child = spawnImpl(cmd, args, { stdio: 'ignore', detached: true, windowsHide: true }); + if (!child || typeof child.unref !== 'function') continue; + child.on?.('error', () => {}); + child.unref(); + return label; + } catch (err) { + log?.(`${label}: ${err?.code || err?.message || err}`); + } + } + return null; +} diff --git a/test/open-browser.test.js b/test/open-browser.test.js new file mode 100644 index 00000000..78ae2884 --- /dev/null +++ b/test/open-browser.test.js @@ -0,0 +1,94 @@ +// openBrowser(): 用玩家的默认浏览器打开页面,且不会把浏览器拉成提权进程。 +// 背景:`rundll32 url.dll,FileProtocolHandler` 继承调用方令牌,从提权终端启动会把 Edge 也拉成提权,之后 Edge 每次 +// 都弹「现有实例正在以提升的权限运行」;交给 shell(explorer.exe )则由**已经在运行**的、非提权的 shell 实例 +// 转发给默认浏览器。 +// 另外这里**故意没有** `cmd /c start "" ` 这一档:cmd 会重新解析 /c 之后的整串,URL 里的 `&` 被当成分隔符, +// 浏览器只收到被截断的地址(见最后一条测试)。 +import { test, describe } from 'node:test'; +import assert from 'node:assert/strict'; +import { browserCommands, openBrowser } from '../scripts/open-browser.mjs'; + +// 这一档是给 Windows 用的,CI 却在 Linux 上跑:探测「C:\Windows\explorer.exe 在不在」必须能被注入, +// 否则测试就在断言**运行这台机器**的文件系统——Linux 上该路径不存在,测试自然红。 +const hasWin = () => true; // 假装 SystemRoot 下该有的可执行文件都在 +const noExplorer = (p) => !/explorer\.exe$/i.test(p); // 只缺 explorer.exe,rundll32 还在 +const emptyWin = () => false; // 假装一个都没找到 +const WIN = { platform: 'win32', env: { SystemRoot: 'C:\\Windows' }, exists: hasWin }; + +describe('openBrowser: 默认浏览器 + 不提权', () => { + test('explorer.exe 在就用它:URL 原样交给 shell,由默认浏览器打开', () => { + const cmds = browserCommands('http://127.0.0.1:3000/', WIN); + assert.deepEqual(cmds.map((c) => c.label), ['explorer']); + assert.equal(cmds[0].cmd, 'C:\\Windows\\explorer.exe', '走 Windows 绝对路径,且分隔符是反斜杠'); + assert.deepEqual(cmds[0].args, ['http://127.0.0.1:3000/'], 'URL 原样交给 shell,由默认浏览器打开'); + // 不能是 rundll32:从提权终端启动时它会把浏览器也提权 + assert.notEqual(cmds[0].label, 'rundll32'); + // 路径必须用 win32 语义拼:Linux 上跑测试时 path.join 是 posix,会拼出 C:\Windows/explorer.exe 这种混合分隔符 + for (const c of cmds) assert.ok(!c.cmd.includes('/'), `${c.cmd} 不该出现正斜杠`); + }); + + test('explorer.exe 不在才退到 rundll32,且只有这一档', () => { + const cmds = browserCommands('http://x/', { platform: 'win32', env: { SystemRoot: 'C:\\Windows' }, exists: noExplorer }); + assert.deepEqual(cmds.map((c) => c.label), ['rundll32']); + assert.equal(cmds[0].cmd, 'C:\\Windows\\System32\\rundll32.exe'); + assert.deepEqual(cmds[0].args, ['url.dll,FileProtocolHandler', 'http://x/']); + }); + + test('两档都找不到时不猜裸命令名,直接没有候选(调用方只打印地址)', () => { + assert.deepEqual(browserCommands('http://x/', { platform: 'win32', env: { SystemRoot: 'C:\\Windows' }, exists: emptyWin }), []); + // 没给 SystemRoot 时按默认的 C:\Windows 找绝对路径 + assert.equal(browserCommands('http://x/', { platform: 'win32', env: {}, exists: hasWin })[0].cmd, 'C:\\Windows\\explorer.exe'); + // windir 也认 + assert.equal(browserCommands('http://x/', { platform: 'win32', env: { windir: 'D:\\Win' }, exists: hasWin })[0].cmd, 'D:\\Win\\explorer.exe'); + }); + + test('macOS 用 open,无桌面的 Linux 不启动任何东西', () => { + assert.deepEqual(browserCommands('http://x/', { platform: 'darwin', env: {} }).map((c) => c.label), ['open']); + assert.deepEqual(browserCommands('http://x/', { platform: 'linux', env: {} }), []); + assert.deepEqual(browserCommands('http://x/', { platform: 'linux', env: { DISPLAY: ':0' } }).map((c) => c.label), ['xdg-open']); + }); + + test('openBrowser 启动那一档并返回它的名字;spawn 失败是异步 error 事件,不影响返回值', () => { + const spawned = []; + let errorListener = false; + const ok = openBrowser('http://127.0.0.1:3000/', { + ...WIN, + spawnImpl: (cmd, args) => { + spawned.push([cmd, args]); + // 真实 ChildProcess:ENOENT / EACCES 不是抛出来,而是之后 emit('error') + return { unref() {}, on(ev) { if (ev === 'error') errorListener = true; } }; + }, + }); + assert.equal(ok, 'explorer'); + assert.deepEqual(spawned, [['C:\\Windows\\explorer.exe', ['http://127.0.0.1:3000/']]]); + assert.ok(errorListener, '必须挂 error 监听,否则未处理的 error 事件会让启动器崩掉'); + }); + + test('没有可用的启动方式时返回 null(调用方只打印地址)', () => { + assert.equal(openBrowser('http://x/', { platform: 'linux', env: {} }), null); + assert.equal(openBrowser('http://x/', { platform: 'win32', env: {}, exists: emptyWin }), null); + // spawn 同步抛错(现实中不该发生)只会被记下来然后继续找下一档,这里没有下一档 + const logged = []; + assert.equal(openBrowser('http://x/', { ...WIN, spawnImpl: () => { throw new Error('no'); }, log: (m) => logged.push(m) }), null); + assert.equal(logged.length, 1); + }); + + test('不带 `cmd /c start` 这一档:URL 里的 & 会被 cmd 当成命令分隔符而截断', () => { + // 房间链接就长这样:`?room=ABCD&name=…`。交给 `cmd /c start "" ` 时,cmd 会在 & 处断开, + // 先执行 `start "" <截断到 & 的地址>`,再拿剩下半截当第二条命令 —— 浏览器打开的是错的地址。 + const url = 'http://127.0.0.1:3000/?room=ABCD&name=me'; + const cmds = browserCommands(url, WIN); + assert.ok(!cmds.some((c) => /^cmd(\.exe)?$/i.test(c.cmd)), '候选里不该再有 cmd.exe'); + assert.ok(!cmds.some((c) => c.args.includes('start')), '也不该再用 start'); + // 每个候选都把完整 URL 作为**一个 argv 元素**传下去:CreateProcess 直接收参数数组,不经过 cmd 解析 + for (const c of cmds) assert.ok(c.args.includes(url), `${c.label} 必须原样收到完整 URL`); + }); + + test('默认用真实文件系统探测(这台机器上跑得起来就说明探测没被写坏)', () => { + // 不注入 exists:结果取决于当前主机,但**不该抛异常**,且候选数量与平台一致 + const cmds = browserCommands('http://x/', { platform: process.platform, env: process.env }); + const want = process.platform === 'win32' || process.platform === 'darwin' ? 1 + : (process.env.DISPLAY || process.env.WAYLAND_DISPLAY ? 1 : 0); + assert.equal(cmds.length, want); + }); +});