feedback5 R19B: the round-start banner reads 观战中 to an eliminated player and to a spectator seat instead of 资金已到账 — the server pays round income only to the players still in (startRound runs ps.startRound for alivePlayers(), eliminate() zeroes funds and pendingFunds); phaseBanner takes the viewer { alive, spectator } from the match screen (a spectator seat has no row in m.public); the idea from PR #237 (not merged: it sits on the #189 / #191 stack); GitHub #236; golden: unchanged (client text only)
This commit is contained in:
1 parent
0b306baa49
commit
7d97b80bfd
5 files changed
+54
-4
No files matched your search
@@ -1856,3 +1856,20 @@ are.
|
||||
intents too (+3 layers, ATK, block). Two NORMAL copies of one item merge (the official rule), so two 空弦 need a normal
|
||||
and an 进阶 set; and the pair counts once toward the 3 members.
|
||||
- Pinned: `test/content/feedback5-cb1-pins.test.js`.
|
||||
|
||||
#### 25.22.2 GitHub #236 「被淘汰后每回合开始横幅仍显示「资金已到账」(观战席同理)」 (@2321Robin, with PR #237): the round-start banner reads 观战中 to an eliminated player and a spectator seat — `ui/gameLogic/phases.js phaseBanner`, `screens/game.js`
|
||||
|
||||
- **Seen** (a real Match with fake battles: three humans and a spectator seat, p_0 out of LP at round 1's settlement):
|
||||
at the round-2 start p_0 (funds 0, pending 0) and the spectator seat (no seat, no funds) got 「第 2 回合 · 资金已到账」,
|
||||
the same as p_1 (funds 5). The sub had been fixed text since 0.1.0.
|
||||
- **Official**: no rule for the banner's text. The money: round income goes only to the players still in.
|
||||
`startRound` runs `ps.startRound` (income + pending coins) for `alivePlayers()` only, and `eliminate()` zeroes
|
||||
`funds` / `pendingFunds` (server/match/match/phases.js, player/round.js). An eliminated player keeps watching
|
||||
(research 09: KEEP_WATCH).
|
||||
- **Now**: `phaseBanner(phase, pub, { alive, spectator })`. The match screen passes its `alive` and `spectator`.
|
||||
`alive` is false for an eliminated player and for a spectator seat. A spectator seat has no row in m.public, so `pub`
|
||||
alone cannot tell. For those viewers ROUND_START's sub is 「观战中」 (en "Spectating", the combat HUD's spectator
|
||||
caption). A player still in keeps 「资金已到账」. The title and the other phases do not change. PR #237 was read for the
|
||||
idea only: its fourth `alive` argument sits on top of the #189 / #191 stack and Match.js changes, so it was not merged.
|
||||
- Golden: unchanged (client text only). Tests: `test/ui/gameLogic.test.js` +1 (a player still in, an eliminated
|
||||
player, a spectator seat, the screen's call). It fails on the parent: 「资金已到账」 where 「观战中」 is expected.
|
||||
Reference in new issue
Block a user