feedback1 WB: 战术决策 drawn with replacement like the 4 official drafts; R11 ally cards weighted by the screenshots

The user: "战术决策也按官方改成可以重复吧". The 4 official 战术决策 (R11 of
matches 7, 9, 18 and 20) show six cards each; match 7 offers 补给 twice.

- Every 战术决策 card is drawn on its own (with replacement), so the same
  card can come twice. choices.js tacticDraftCards / tacticCard.
- R11 (绝境 / 终极, the round of the screenshots; choices.json tacticDraft,
  build-data TACTIC_DRAFT): only the ally cards, weighted 1 + the official
  cards each showed on. All 24 official cards are ally cards (no 排斥 /
  责罚 / 裁决, no terrain card: about 0.04 % for the previous draw) and
  列装 / 财富 / 补给 / 整备 / 升华 made 12 of them (uniform: about 4.6).
  Other rounds (标准 / 险境, no screenshot) keep every card, uniform, with
  replacement too. The weights and the R11 terrain exclusion are assumed.
- The header is the official "进行协同调整，做好迎战准备。".
- Identical cards are separate cards: own index, own object; a pick
  applies its card once and leaves the twin pickable; two picks of a team
  card stack. Match / bot / overlay already go by index.
- Tests: official drafts vs data, generated R11 / solo / earlier rounds,
  a seeded draft with 补给 twice, co-op and solo E2E picks of twins, the
  bot, the overlay, and a headless-Chrome render (game-mock variant=tactic
  is now the official match 7 draft). Tests that drive given tactic cards
  lay them out explicitly. The 奥术 Final Assault test takes the first of
  a few seeds whose bots pair two 奥术 players (the draws moved seed 12).

test/ui/feedback1-tactic.e2e.test.js

@@ -0,0 +1,87 @@
+// The 战术决策 overlay with the same card twice, in headless Chrome (puppeteer-core + system Chrome) through the mock
+// harness (public/dev/game-mock.html ?phase=SP_DRAFT&variant=tactic: the official 战术决策 of match 7 R11 — 补给 in
+// slots 1 and 2; the user: "战术决策也按官方改成可以重复吧"). Opt-in: SP_E2E=1.
+//
+//   SP_E2E=1 node --test test/ui/feedback1-tactic.e2e.test.js
+//
+// Two identical cards render as two cards with the same face (name, 全队获得, text) under the official header; a
+// teammate taking the first leaves the second pickable; two taps on the second pick it — its own index goes to the
+// server (g.choice), only it shows my avatar. Screenshots: test/e2e/out/fb1-tactic-*.png.
+import { test, describe, before, after } from 'node:test';
+import assert from 'node:assert/strict';
+import { existsSync, mkdirSync } from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '../..');
+const OUT = path.join(ROOT, 'test/e2e/out');
+const CHROME = process.env.CHROME_PATH || '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome';
+const ENABLED = process.env.SP_E2E === '1' && existsSync(CHROME);
+const sleep = (ms) => new Promise((r) => setTimeout(r, ms));
+
+describe('战术决策: the same card twice (mock harness, headless Chrome)', { skip: !ENABLED && 'set SP_E2E=1 (and have Chrome) to run' }, () => {
+  let srv;
+  let browser;
+  let base;
+
+  before(async () => {
+    const { startServer } = await import('../../server/index.js');
+    const puppeteer = (await import('puppeteer-core')).default;
+    srv = await startServer({ port: 0, host: '127.0.0.1', quiet: true });
+    base = `http://127.0.0.1:${srv.port}`;
+    browser = await puppeteer.launch({ executablePath: CHROME, headless: true, args: ['--no-sandbox'] });
+    mkdirSync(OUT, { recursive: true });
+  });
+
+  after(async () => {
+    await browser?.close();
+    await srv?.close();
+  });
+
+  const cards = (page) => page.$$eval('.spov__grid .spcard', (els) => els.map((c) => ({
+    name: c.querySelector('.spcard__name')?.textContent, taken: c.classList.contains('is-taken'), mine: c.classList.contains('is-mine'),
+    armed: c.classList.contains('is-armed'), disabled: c.disabled, badge: !!c.querySelector('.spcard__taker'),
+    team: !!c.querySelector('.spcard__tag--team'), desc: c.querySelector('.spcard__desc')?.textContent, w: c.getBoundingClientRect().width,
+  })));
+
+  for (const [name, w, h, touch] of [['756x366', 756, 366, true], ['1920x1080', 1920, 1080, false]]) {
+    test(`${name}: two 补给 are two cards; the second stays pickable after the first is taken, and picking it sends its own index`, { timeout: 120000 }, async () => {
+      const page = await browser.newPage();
+      await page.setViewport({ width: w, height: h, deviceScaleFactor: 1, isMobile: touch, hasTouch: touch });
+      const problems = [];
+      page.on('pageerror', (e) => problems.push(`pageerror: ${e.message}`));
+      page.on('console', (m) => { if (m.type() === 'error') problems.push(`console: ${m.text()}`); });
+      await page.goto(`${base}/dev/game-mock.html?shot=1&phase=SP_DRAFT&variant=tactic`, { waitUntil: 'networkidle0' });
+      await page.waitForSelector('.spov__grid .spcard', { timeout: 20000 });
+      await sleep(600);
+      const head = await page.$eval('.spov__title', (e) => e.textContent);
+      assert.ok(head.includes('战术决策') && head.includes('进行协同调整，做好迎战准备。'), `the official header: ${head}`);
+      // the teammate p4 has taken the first 补给 (slot 0)
+      await page.evaluate(() => { const S = globalThis.__MOCK__.S(); S.pub.sp = { ...S.pub.sp, picks: { p4: 0 }, turn: 'p1' }; globalThis.__MOCK__.pushPublic(); });
+      await sleep(300);
+      let c = await cards(page);
+      assert.equal(c.length, 6);
+      assert.deepEqual(c.map((x) => x.name), ['补给', '补给', '谢拉格驰援', '列装', '莫斯提马的盟誓', '升华']);
+      assert.deepEqual([c[0].team, c[0].desc, Math.round(c[0].w)], [c[1].team, c[1].desc, Math.round(c[1].w)], 'the same face');
+      assert.ok(c[0].team && /2.*次刷新/.test(c[0].desc), `补给: ${c[0].desc}`);
+      assert.ok(c[0].taken && c[0].badge && c[0].disabled, 'the first twin: taken, with the taker\'s avatar');
+      assert.ok(!c[1].taken && !c[1].badge && !c[1].disabled, 'the second twin: free');
+      await page.screenshot({ path: path.join(OUT, `fb1-tactic-${name}.png`) });
+      // two taps on the second twin
+      const tap = async (i) => { const btn = (await page.$$('.spov__grid .spcard'))[i]; if (touch) await btn.tap(); else await btn.click(); await sleep(250); };
+      await tap(1);
+      c = await cards(page);
+      assert.deepEqual(c.map((x) => x.armed), [false, true, false, false, false, false], 'only the tapped twin is armed');
+      await page.screenshot({ path: path.join(OUT, `fb1-tactic-${name}-armed.png`) });
+      await tap(1);
+      const picks = await page.evaluate(() => ({ ...globalThis.__MOCK__.S().pub.sp.picks }));
+      assert.deepEqual(picks, { p4: 0, p1: 1 }, 'g.choice sent the second twin\'s index');
+      await sleep(250);
+      c = await cards(page);
+      assert.ok(c[1].mine && c[1].badge, 'the second twin is mine');
+      assert.ok(c[0].taken && !c[0].mine, 'the first twin stays the teammate\'s');
+      assert.deepEqual(problems, []);
+      await page.close();
+    });
+  }
+});

test/ui/feedback1-tactic.test.js

@@ -0,0 +1,100 @@
+// The 战术决策 overlay with the same card twice (the user: "战术决策也按官方改成可以重复吧"; official match 7 R11: 补给 ×2).
+// A real server draft (server/match/choices.js generateDraft → cardView; co-op 绝境 R11, seed 30: 补给 twice), through
+// m.public's normalisation (ui/gameLogic.js normalizeSp), rendered by the overlay's pure view (ui/choiceOverlay.js
+// ChoiceView): two identical cards are two buttons keyed by their index, with the same face (name, icon, 全队获得, text) —
+// selecting one does not select the other, a teammate taking one leaves the other pickable, and the pick sends that
+// card's own index. The header is the official one. The browser render is test/ui/feedback1-tactic.e2e.test.js (SP_E2E=1).
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import { readFileSync } from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '../..');
+
+// the browser data store reads the real data files from disk
+globalThis.fetch = async (url) => {
+  const name = String(url).split('/').pop();
+  try {
+    const body = readFileSync(path.join(ROOT, 'data', name), 'utf8');
+    return { ok: true, status: 200, json: async () => JSON.parse(body) };
+  } catch {
+    return { ok: false, status: 404, json: async () => ({}) };
+  }
+};
+
+const { ChoiceView, cardPickable, spTap, armedCard, resolveSpCard } = await import('../../public/js/ui/choiceOverlay.js');
+const { normalizeSp } = await import('../../public/js/ui/gameLogic.js');
+const { DATA } = await import('../match/harness.js');
+const { GameData } = await import('../../server/match/gamedata.js');
+const { generateDraft, cardView } = await import('../../server/match/choices.js');
+const { createRng } = await import('../../server/sim/rng.js');
+const { data } = await import('../../public/js/data.js');
+
+/** Every vnode of a preact tree (htm output), depth first. */
+function* walk(v) {
+  if (Array.isArray(v)) { for (const x of v) yield* walk(x); return; }
+  if (!v || typeof v !== 'object') return;
+  yield v;
+  yield* walk(v.props?.children);
+}
+const hasClass = (v, c) => typeof v?.props?.class === 'string' && v.props.class.split(/\s+/).includes(c);
+const text = (v) => [...walk(v)].flatMap((n) => (typeof n.props?.children === 'string' ? [n.props.children] : Array.isArray(n.props?.children) ? n.props.children.filter((x) => typeof x === 'string') : [])).join('');
+
+await data.loadAll('items', 'effects', 'choices', 'assets', 'chess', 'bonds');
+
+test('战术决策 overlay: the same card twice is two cards — own keys, same face, own selection, one taken leaves the other pickable', () => {
+  const d = generateDraft(new GameData(DATA, 'mode_multi_hard'), createRng(30), 11, { stageId: 'act1autochess_m02' });
+  assert.equal(d.family, 'tactic');
+  const at = d.cards.flatMap((c, i) => (c.name === '补给' ? [i] : []));
+  assert.equal(at.length, 2, 'seed 30: 补给 twice');
+  const [a, b] = at;
+  const players = [{ playerId: 'me', seat: 0, name: 'Me' }, { playerId: 'p2', seat: 1, name: 'P2' }];
+  const pub = (picks) => normalizeSp({ family: 'tactic', name: d.name, desc: d.desc, cards: d.cards.map(cardView), order: ['p2', 'me'], turn: Object.keys(picks).length ? 'me' : 'p2', picks, taken: {} }, players);
+  const view = (sp, armed = null) => [...walk(ChoiceView({ pub: { players, deadline: 0 }, sp, myId: 'me', solo: false, armed }))];
+  const cardsOf = (nodes) => nodes.filter((n) => hasClass(n, 'spcard'));
+
+  // the official header
+  let sp = pub({});
+  const all = view(sp);
+  assert.ok(text(all.find((n) => hasClass(n, 'spov__title'))).includes('战术决策'));
+  assert.equal(all.find((n) => hasClass(n, 'spov__desc')).props.children.props.text, '进行协同调整，做好迎战准备。');
+
+  // six buttons keyed by index; the twins have the same name, icon, team tag and text
+  let cards = cardsOf(all);
+  assert.equal(cards.length, 6);
+  assert.deepEqual(cards.map((c) => c.key), [0, 1, 2, 3, 4, 5], 'keyed by index, never by card id');
+  const face = (c) => ({ name: [...walk(c)].find((n) => hasClass(n, 'spcard__name')).props.children, team: [...walk(c)].some((n) => hasClass(n, 'spcard__tag--team')), title: c.props.title });
+  assert.deepEqual(face(cards[a]), face(cards[b]));
+  assert.equal(face(cards[a]).name, '补给');
+  assert.equal(face(cards[a]).team, true, '全队获得');
+  assert.deepEqual(resolveSpCard(sp.cards[a], 'tactic'), resolveSpCard(sp.cards[b], 'tactic'));
+  assert.equal(sp.cards[a].id, sp.cards[b].id);
+  assert.notEqual(sp.cards[a].idx, sp.cards[b].idx);
+
+  // the teammate takes the first twin: only that card shows the taker; the second twin is still mine to pick
+  sp = pub({ p2: a });
+  assert.equal(sp.cards[a].takenBy, 'p2');
+  assert.equal(sp.cards[b].takenBy, null);
+  assert.equal(cardPickable(sp, sp.cards[a], { myId: 'me', solo: false }), false);
+  assert.equal(cardPickable(sp, sp.cards[b], { myId: 'me', solo: false }), true);
+  cards = cardsOf(view(sp));
+  assert.ok(hasClass(cards[a], 'is-taken') && !hasClass(cards[b], 'is-taken'));
+  assert.ok([...walk(cards[a])].some((n) => hasClass(n, 'spcard__taker')) && ![...walk(cards[b])].some((n) => hasClass(n, 'spcard__taker')));
+  assert.equal(cards[a].props.disabled, true);
+  assert.equal(cards[b].props.disabled, false);
+
+  // two taps on the second twin: it alone is armed, then its own index is sent
+  let r = spTap(null, b, cardPickable(sp, sp.cards[b], { myId: 'me', solo: false }));
+  assert.deepEqual(r, { armed: b, pick: null });
+  assert.equal(armedCard(r.armed, sp, { myId: 'me', solo: false }), b);
+  cards = cardsOf(view(sp, r.armed));
+  assert.deepEqual(cards.map((c) => hasClass(c, 'is-armed')), cards.map((_, i) => i === b), 'only the tapped twin is armed');
+  r = spTap(r.armed, b, true);
+  assert.deepEqual(r, { armed: null, pick: b });
+  // after my pick: the first twin the teammate's, the second mine
+  sp = pub({ p2: a, me: b });
+  cards = cardsOf(view(sp));
+  assert.ok(hasClass(cards[b], 'is-mine') && !hasClass(cards[a], 'is-mine'));
+  assert.ok(cards.every((c) => c.props.disabled), 'nothing left to pick for me');
+});