A skill clip with no Begin and no Idle plays once at its own length: 德克萨斯 S2 剑雨 and the other instant skills of that shape (#160)

Deploy-time passives without a duration send the same 0.5 s skill window, so 琳琅诗怀雅's passives play their clip too. Contributed by @xcdoge.

test/render/feedback4-texas-skill-clip.test.js

@@ -0,0 +1,121 @@
+// test/render/feedback4-texas-skill-clip.test.js — player report (after 0.1.3): 德克萨斯 S2「剑雨」释放时不播放技能动画.
+//
+// Her Front model's skill roles are { begin: null, loop: 'Skill', end: null } — the 2.17 s 剑雨 clip — and both her
+// skills are instant (server/sim/skills.js fires 'skill' 1 and 0 inside one tick and holds only the anim code SKILL for
+// 0.5 s, snapshot.js animOf). spine.js setSkill(true) had a branch for a Begin clip and otherwise just re-played the
+// base clip, so the skill clip never played: the actor showed its idle through the whole cast. The same clip shape
+// (no Begin, no own Idle) carries 58 instant skills across the manifest.
+//
+// Real manifest entries, headless fake PIXI (test/render/fakepixi.js), like feedback3-skill-idle.test.js.
+
+import { test, before, after } from 'node:test';
+import assert from 'node:assert/strict';
+import { readFileSync } from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { installFakePixi } from './fakepixi.js';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '../..');
+const assets = JSON.parse(readFileSync(path.join(ROOT, 'data/assets.json'), 'utf8'));
+
+let fake, SpineActor;
+before(async () => {
+  fake = installFakePixi();
+  ({ SpineActor } = await import('../../public/js/render/spine.js'));
+});
+after(() => fake.restore());
+
+/** An actor of a real operator's Front model with its equipped skill, recording every clip set / queued. */
+function actor(charId, skillIndex) {
+  const entry = assets.chars[charId].spine.front;
+  const a = new SpineActor({ animations: Object.keys(entry.animations).map((name) => ({ name })) }, entry);
+  a.setSkillIndex(skillIndex);
+  a.log = [];
+  const st = a.spine.state;
+  const set = st.setAnimation, add = st.addAnimation;
+  st.setAnimation = (i, name, loop) => { a.log.push(['set', name, !!loop]); return set(i, name, loop); };
+  st.addAnimation = (i, name, loop) => { a.log.push(['queue', name, !!loop]); return add(i, name, loop); };
+  return a;
+}
+const run = (a, s, dt = 1 / 60) => { for (let t = 0; t < s - 1e-9; t += dt) a.update(dt); };
+const names = (a) => a.log.map(([, n]) => n);
+
+test('德克萨斯 S2 剑雨: an instant skill with no Begin clip plays its Skill clip and keeps it for the clip length', () => {
+  const a = actor('char_102_texas', 1);
+  assert.deepEqual([a.roles.skill.begin, a.roles.skill.loop, a.roles.skill.end, a.roles.skill.idle], [null, 'Skill', null, null], 'the manifest roles');
+  assert.equal(a.dur('Skill'), 2.167, 'the 剑雨 clip');
+  a.setSkill(true);
+  assert.deepEqual(a.log, [['set', 'Skill', false]], 'the skill clip itself, played once');
+  a.setSkill(false);   // the sim fires 'skill' 1 and 0 in the same tick: the flag is already off
+  run(a, 1);
+  assert.equal(a.mode, 'skillBegin');
+  assert.equal(a.current, 'Skill', 'still on screen halfway through the cast');
+  run(a, 1.3);
+  assert.equal(a.mode, 'base');
+  assert.equal(a.current, 'Idle', 'back to the idle once the clip has run');
+  assert.deepEqual(names(a), ['Skill', 'Idle'], 'no end clip, no base flash before it');
+});
+
+test('the other instant skills with the same clip shape play their clip too (char_140_whitew S1 日晷, char_206_gnosis S2 零度爆发, 德克萨斯 S1)', () => {
+  for (const [charId, idx, clip] of [['char_140_whitew', 0, 'Skill'], ['char_206_gnosis', 1, 'Skill_2'], ['char_102_texas', 0, 'Skill']]) {
+    const a = actor(charId, idx);
+    assert.equal(a.roles.skill.begin, null, `${charId} S${idx + 1}: no Begin clip`);
+    assert.equal(a.roles.skill.idle, null, `${charId} S${idx + 1}: no own Idle`);
+    a.setSkill(true);
+    assert.equal(a.current, clip, `${charId} S${idx + 1} plays ${clip}`);
+  }
+});
+
+test('a skill that stays on (银灰 S3 真银斩: same clip shape, 1.33 s clip) plays it once and then rests — no freeze on its last frame', () => {
+  const a = actor('char_172_svrash', 2);
+  assert.deepEqual([a.roles.skill.begin, a.roles.skill.loop, a.roles.skill.idle], [null, 'Skill', null]);
+  a.setSkill(true);
+  assert.equal(a.current, 'Skill');
+  run(a, 2);
+  assert.equal(a.mode, 'base', 'the one-shot window is over');
+  assert.equal(a.current, 'Idle', 'rests on the idle while the skill is still running');
+  a.log.length = 0;
+  a.attack(1.2);
+  assert.equal(a.current, 'Skill', 'attacks still use the skill loop, as before');
+  a.setSkill(false);
+  assert.equal(a.current, 'Idle', 'no End clip: straight back to the idle');
+});
+
+test('unchanged: a Begin clip still runs into its queued next clip, a skill with its own Idle still idles, and End still closes the skill', () => {
+  const b = actor('char_4207_branch', 1);   // 折桠 S2: Skill_2_Begin → Skill_2_Idle (community report #23)
+  b.setSkill(true);
+  assert.deepEqual(b.log, [['set', 'Skill_2_Begin', false], ['queue', 'Skill_2_Idle', true]]);
+  const n = actor('char_1014_nearl2', 2);   // 耀骑士临光 S3: no Begin, own Idle — plays that idle at once
+  n.setSkill(true);
+  assert.deepEqual(n.log, [['set', 'Skill_3_Idle', true]]);
+  const u = actor('char_337_utage', 1);     // 宴: Begin → loop, unchanged
+  u.setSkill(true);
+  assert.deepEqual(u.log, [['set', 'Skill_Start', false], ['queue', 'Skill_Loop', true]]);
+});
+
+test('the deploy-time passives the sim now opens a window for play their clip (琳琅诗怀雅 S1/S2: kind passive, no duration)', () => {
+  // server/sim/skills.js `_startPassive` fires ['skill', id, 1] at the deployment and 0 after SKILL_ANIM_WINDOW (0.5 s),
+  // which is shorter than her 1 s clips: the actor holds the clip to its own end and then idles.
+  for (const [idx, clip] of [[0, 'Skill_1'], [1, 'Skill_2']]) {
+    const a = actor('char_1033_swire2', idx);
+    assert.deepEqual([a.roles.skill.begin, a.roles.skill.loop, a.roles.skill.idle], [null, clip, null]);
+    assert.equal(a.dur(clip), 1);
+    a.setSkill(true);
+    assert.equal(a.current, clip, `S${idx + 1} plays ${clip} at the deployment`);
+    run(a, 0.5);
+    a.setSkill(false);                      // the sim closes the window at 0.5 s …
+    run(a, 0.4);
+    assert.equal(a.current, clip, '… the clip is still running (it is 1 s long)');
+    run(a, 0.2);
+    assert.equal(a.mode, 'base');
+    assert.equal(a.current, 'Idle', 'and then back to the idle');
+  }
+});
+
+test('a skill clip that IS the normal attack clip is not played as a skill animation (no attack twitch at the deployment)', () => {
+  const a = actor('char_1028_texas2', 0);   // 缄默德克萨斯 S1: anims.skill.loop === anims.attack.loop ('Attack')
+  assert.equal(a.roles.skill.loop, a.roles.attack.loop);
+  a.setSkill(true);
+  assert.deepEqual(a.log, [['set', 'Idle', true]], 'falls through to the base clip, as before');
+  assert.equal(a.current, 'Idle');
+});

test/sim/skills.test.js

@@ -433,3 +433,28 @@ test('spCostMul changes (绝技-style) keep SP within bounds and convert overflo
   assert.equal(u.skill.charges, 1);
   assert.ok(u.skill.sp <= u.skill.spCost);
 });
+
+test('a deploy-time passive fires the skill animation window; a passive with a duration does not (yet)', () => {
+  // 琳琅诗怀雅 S1 仗义疏财 / S2 “见面礼”: kind 'passive', no duration — the sim used to start them silently, so the
+  // client got no 'skill' event and never played the clip the manifest carries (player report follow-up). The window is
+  // the same one an instant cast uses: on at the deployment, off 0.5 s later (SKILL_ANIM_WINDOW), the passive itself
+  // staying active (it never ends before the unit does).
+  const h = makeBattle({ units: [{ chessId: 'chess_char_3_04_a', row: 10, col: 6 }], autoFinish: false, timeLimit: 30 });
+  h.run(0.2);
+  const u = h.unit('chess_char_3_04_a');
+  assert.equal(u.skill.kind, 'passive');
+  assert.equal(u.skill.active, true, 'the passive is active from the deployment');
+  assert.deepEqual(h.eventsOf('skill').map((e) => e[2]), [1], 'the window opens at the deployment');
+  assert.ok(u.skillAnimUntil > h.b.time, 'skillAnimUntil drives ANIM.SKILL on the client');
+  h.run(0.6);
+  assert.deepEqual(h.eventsOf('skill').map((e) => e[2]), [1, 0], 'and closes 0.5 s later');
+  assert.equal(u.skill.active, true, 'the passive itself never ends');
+
+  // a passive WITH a duration (缄默德克萨斯 S2 阵雨连绵, 8 s): left alone — the sim holds it active until death, so how
+  // long its stance should show is a separate question
+  const t = makeBattle({ units: [{ chessId: 'chess_char_4_16_a', row: 10, col: 6, skillIndex: 1 }], autoFinish: false, timeLimit: 30 });
+  t.run(0.6);
+  assert.equal(t.unit('chess_char_4_16_a').skill.kind, 'passive');
+  assert.equal(t.unit('chess_char_4_16_a').skill.active, true);
+  assert.deepEqual(t.eventsOf('skill'), [], 'no window for a timed passive');
+});