Hit tiles: positions round half to even (PRTS 作战机制); enemies held just inside the field edge

test/content/feedback5-wv-summon-triggers.test.js

@@ -50,7 +50,9 @@ test('#2 麦哲伦 S1: an enemy on a standing drone\'s range (air units too) cas
     const { h, u, ps } = field(MG, 0, [[DRONE_F, 12, 9]]);
     assert.equal(u.skill.rule, 'DEFAULT');
     assert.ok(ps[0].alive && ps[0].rangeKeySet.has(12 * COLS + 10) && outOfHerRange(u, 12, 10), 'the setup');
-    h.spawn('enemy_dummy', { pos: [11, 13] });   // outside every area
+    // on the field (rows 9–12, cols 0–10) and outside every area: (11, 13) would be held at the field's edge, on (11, 10) —
+    // the drone's area
+    h.spawn('enemy_dummy', { pos: [11, 6] });
     assert.ok(!casts(h, u), 'nobody in her range or a drone\'s: no cast');
     h.spawn('enemy_dummy', { pos: [12, 10] });
     assert.ok(h.runUntil(() => u.skill.activations === 1, 1), 'an enemy on the drone\'s range casts S1');

test/content/kits_t6.test.js

@@ -1119,8 +1119,9 @@ test('异客: the S3 storm is range x-1 — the 13-tile diamond — around the t
   };
   // in the diamond (|Δrow| + |Δcol| ≤ 2 by tile): (2, 0) / (0, −2) / (1.95, 0.4) lay outside the old 1.5 circle
   for (const off of [[0, 0], [2, 0], [0, -2], [-2, 0], [1.45, 1.45], [1.95, 0.4]]) assert.equal(strikes(off), 8, `(${off}) struck by all 8 strikes`);
-  // outside it: tile (+2, +1), and tile (+3, 0) — (1.55, 1.05) was inside the old circle around the target's position
-  for (const off of [[2, 1], [1.55, 1.05], [0, 2.6]]) assert.equal(strikes(off), 0, `(${off}) never struck`);
+  // outside it: tile (+2, +1), and tile (+3, 0) — (1.55, 1.05) was inside the old circle around the target's position;
+  // three tiles off along the columns, as the field has no row 13 (a probe there is held on row 12, inside the diamond)
+  for (const off of [[2, 1], [1.55, 1.05], [2.6, 0]]) assert.equal(strikes(off), 0, `(${off}) never struck`);
 });
 
 test('蕾缪安: 通缉 needs a continuous 8 s stay in a 拉特兰 range (leaving restarts the count)', () => {

test/content/op_wang.test.js

@@ -330,7 +330,7 @@ test('S2 连星 (AUTO, SP_FULL): a triggered piece hits every enemy on its conne
     assert.deepEqual([sk.spCost, sk.bb['attack@atk_scale'], sk.bb['attack@move_speed'], sk.bb['attack@duration']], elite ? [16, 4.8, -0.4, 6] : [17, 4.2, -0.35, 6], `T${tier}`);
     const { h, u } = field({ tier, elite, skill: 1, stones: [[10, 6], [10, 7]] });
     const onLine = h.spawn('enemy_fly', { pos: [10, 9] });       // 3 tiles right of (10,6)…(10,7)+2: on the horizontal line
-    const beyond = h.spawn('enemy_dummy', { pos: [10, 11] });    // 4 tiles past (10,7)
+    const beyond = h.spawn('enemy_dummy', { pos: [10, 2] });     // 4 tiles before (10,6) (the field ends at column 10: no tile 4 past (10,7))
     const vertical = h.spawn('enemy_dummy', { pos: [12, 7] });   // its battle-start 跟子 (11,7) is 上 of it: the vertical line is on
     const off = h.spawn('enemy_dummy', { pos: [9, 4] });         // on neither line
     const trig = h.spawn('enemy_runner', { pos: [10, 7] });

test/golden/standins.json

@@ -238,10 +238,10 @@
         "enemy_1071_dftman": [63,63,0,455,243855],
         "enemy_1072_dlancer": [60,55,5,22144,476588]
       },
-      "hooks": [1,178,6234,1000,1000,2074,2072,74,158,168,32,32,0,36983,4066,67,158,10,1,160,2,0,11],
+      "hooks": [1,178,6234,1000,1000,2074,2072,74,158,168,32,32,0,36983,4064,67,158,10,1,160,2,0,11],
       "events": {"atk":1142,"bounty":4,"deploy":18,"die":158,"dmg":2072,"engage":11,"fx":161,"heal":53,"layer":2,"leak":10,"skill":64,"spawn":172,"status":472},
       "fx": {"aoe":11,"dodge":14,"dp":38,"garrison":2,"revive":1,"slash":77,"sp":13,"spGain":3,"telegraph":2},
-      "snaps": "484fd662 19a9b252 827467e6 d8836b51 4e1a5c20 f5f33eaf 009d313f 487fac84 6e33c253 481fa961 eee28282 47fecc48 ec2c4a14 046a7402 d017b22b a2a8910b b53ce9db 2504d954 222d228d 78e5e524 2b44a10f"
+      "snaps": "484fd662 19a9b252 827467e6 5c638330 c6d0b532 c1538ba9 691c2e95 65eab1de e256c73c 337bd270 302985e3 18a84929 737e1169 1cc75867 71696cfe c0e56f12 25c880fa 10b7e655 a65f5fd8 02e1a041 602de50a"
     },
     "standin-05": {
       "about": "normal band 6 as stand-ins: chess_char_6_17_a→char_608_acpion chess_char_6_13_a→char_615_acspec chess_char_6_19_a→char_615_acspec chess_char_6_12_a→char_612_accast chess_char_6_15_a→char_614_acsupo chess_char_6_18_a→char_612_accast chess_char_6_20_a→char_613_acmedc",

test/sim/feedback5-raid-own-board.test.js

@@ -177,8 +177,8 @@ for (const kind of ['boss', 'hidden']) for (const side of ['L', 'R']) {
   });
 }
 
-test('#475: even buildable hand, temporary-storage, side-margin and off-rect tiles remain invalid Raid landings', () => {
-  for (const pos of [[0, 3], [1, 3], [0, 17], [1, 17], [3, 1], [3, 19], [6, 17]]) {
+test('#475: even buildable hand, temporary-storage and side-margin tiles remain invalid Raid landings', () => {
+  for (const pos of [[0, 3], [1, 3], [0, 17], [1, 17], [3, 1], [3, 19]]) {
     const h = emptyHalfLanding({ pos, ranged: true });
     const u = h.unit('probe'), home = [u.tileR, u.tileC];
     h.run(11);
@@ -187,6 +187,16 @@ test('#475: even buildable hand, temporary-storage, side-margin and off-rect til
   }
 });
 
+test('#475: no Raid lands off the rectangle — an enemy spawned on (6,17) is held on the edge row and stands on (5,17)', () => {
+  // Battle._clampPos keeps an enemy FIELD_EDGE_INSET inside the field, so its tile is the edge tile (body.js); the Raid
+  // lands where it would for an enemy put on (5,17), never on row 6
+  const h = emptyHalfLanding({ pos: [6, 17], ranged: true });
+  const u = h.unit('probe');
+  h.run(11);
+  assert.deepEqual([u.tileR, u.tileC], [5, 17]);
+  checkInvariants(h.b);
+});
+
 test('#475: empty-half Raid still respects melee/high-ground, water and occupied/downed-unit reservations', () => {
   for (const glyph of ['h', 'd']) {
     const h = emptyHalfLanding({ pos: [3, 17], glyph });

test/sim/hit-tile-round.test.js

@@ -0,0 +1,53 @@
+// The tile of a target is its position rounded half to even — PRTS 作战机制 「受击方坐标经round函数取整(四舍六入五成双)
+// 得到其所属格坐标，按是否属于该格判定」 — not Math.round, which rounds every tie up: an enemy exactly halfway between
+// columns 10 and 11 (x = 10.5) is on column 10, one at x = 11.5 on column 12.
+
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import { makeBattle, chessRec, enemyRec } from '../helpers/battleHarness.js';
+import { roundHalfEven } from '../../server/sim/detmath.js';
+import { bodyKeys, bodyOnTile, bodyTileReach } from '../../server/sim/body.js';
+import { tileKeyOf } from '../../server/sim/targeting.js';
+import { COLS } from '../../server/sim/constants.js';
+
+test('roundHalfEven: ties to the even integer, the rest to the nearest; never −0', () => {
+  const cases = [[0.5, 0], [1.5, 2], [2.5, 2], [3.5, 4], [10.5, 10], [11.5, 12], [-0.5, 0], [-1.5, -2], [-2.5, -2],
+    [2.4999999999999996, 2], [2.5000000000000004, 3], [-0.4, 0], [-0, 0], [7, 7], [4503599627370495.5, 4503599627370496]];
+  for (const [x, want] of cases) assert.ok(Object.is(roundHalfEven(x), want), `${x} → ${roundHalfEven(x)}, want ${want}`);
+  for (let i = -2000; i <= 2000; i++) {
+    const x = i / 8, v = roundHalfEven(x), d = Math.abs(x - v);
+    assert.ok(Number.isInteger(v) && (d < 0.5 || (d === 0.5 && v % 2 === 0)), `${x} → ${v}`);
+    if (d !== 0.5) assert.equal(v, Math.round(x) + 0, `${x}: away from a tie it is Math.round`);
+  }
+});
+
+test('a point target exactly halfway is on the even tile: bodyKeys, bodyOnTile, bodyTileReach, tileKeyOf', () => {
+  const e = { x: 10.5, y: 3.5 };
+  assert.deepEqual(bodyKeys(e), [4 * COLS + 10]);
+  assert.ok(bodyOnTile(e, 4, 10) && !bodyOnTile(e, 4, 11) && !bodyOnTile(e, 3, 10));
+  assert.equal(bodyTileReach(e, 4, 10), 0);
+  assert.equal(bodyTileReach(e, 4, 12), 2);
+  assert.equal(tileKeyOf(e), 4 * COLS + 10);
+  assert.equal(tileKeyOf({ x: 11.5, y: 2.5 }), 2 * COLS + 12);
+});
+
+test('the battle\'s enemy index puts an enemy at x = 10.5 on column 10, not 11', () => {
+  const h = makeBattle({
+    kind: 'boss', content: 'none', autoFinish: false, timeLimit: 60,
+    defs: {
+      chess: { t_one: chessRec({ id: 't_one', stats: { atk: 100, blockCnt: 0, maxHp: 1e7 }, rangeGrid: [[0, 0]], skill: null }) },
+      enemies: { enemy_still: enemyRec({ key: 'enemy_still', hp: 1e8, speed: 0 }) },
+    },
+    players: [{ playerId: 'p1', seat: 0, side: 'L', coords: 'field', units: [{ uid: 1, kind: 'chess', chessId: 't_one', row: 1, col: 1 }], bonds: {} }],
+  });
+  h.step();
+  const e = h.spawn('enemy_still', { pos: [3, 10], routeIndex: 0 });
+  e.x = 10.5;
+  e.y = 3;
+  h.step();
+  e.x = 10.5;
+  e.y = 3;
+  const u = h.unit('t_one');
+  assert.deepEqual(h.b.enemiesInKeys([3 * COLS + 10], u, { canHitFly: true }).map((x) => x.id), [e.id]);
+  assert.deepEqual(h.b.enemiesInKeys([3 * COLS + 11], u, { canHitFly: true }).map((x) => x.id), []);
+});