feedback2: merge WI — 归溟幽灵鲨's 替身 is drawn (form + status icon), makes no attack and casts nothing, S2's end switches her (GitHub #44)

test/render/feedback2-doll.test.js

@@ -0,0 +1,200 @@
+// test/render/feedback2-doll.test.js — GitHub issue #44 「归鲨死了没替身」 (DESIGN §22.11), client side: a 傀儡师 fighting as
+// its <替身> is in the model form 'doll' (sim professions.js: fx 'substitute' { form: 'doll', dur } … 'swap' / 'dollEnd'
+// { form: null }, UnitInfo `form`), drawn with the skeleton's *_B clips (render/units.js FORMS): 归溟幽灵鲨's Start_B fades
+// the 替身 in, Idle_B, Die_B breaks it apart over its last second, the 本体 comes back on Start_2 (the form's `leave`
+// clip); knocked out as the 替身 she collapses on Die_B_2 and stays so. 0.1.1 drew the 本体 all along. Headless fake PIXI
+// (test/render/fakepixi.js); the clip meanings are checked on the real skeleton when the assets are fetched.
+
+import { test, describe, before, after } from 'node:test';
+import assert from 'node:assert/strict';
+import { readFileSync, existsSync } from 'node:fs';
+import { createRequire } from 'node:module';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { installFakePixi, fakeViewCtx } from './fakepixi.js';
+import { presetCamera } from '../../public/js/render/projection.js';
+import { statusIconKey } from '../../public/js/render/style.js';
+import { STATUS_KEYS } from '../../public/js/render/textures.js';
+import { fxForm } from '../../shared/protocol.js';
+import { makeBattle, enemyRec } from '../helpers/battleHarness.js';
+import { unitInfo } from '../../server/sim/snapshot.js';
+import { DOLL_SWITCH } from '../../server/sim/professions.js';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '../..');
+const assets = JSON.parse(readFileSync(path.join(ROOT, 'data/assets.json'), 'utf8'));
+const GHOST = 'char_1023_ghost2', KAZEMA = 'char_4016_kazema';
+
+let fake, UnitView, FORMS, renderInfo;
+before(async () => {
+  fake = installFakePixi();
+  ({ UnitView, FORMS } = await import('../../public/js/render/units.js'));
+  ({ renderInfo } = await import('../../public/js/render/app.js'));
+});
+after(() => fake.restore());
+
+const tick = () => new Promise((r) => setImmediate(r));
+const cam = () => presetCamera('normal', { width: 1280, height: 720 });
+/** Asset store with the operator's real Front / Back manifest entries and their animation names. */
+function store(id) {
+  const sp = assets.chars[id].spine;
+  return {
+    picture: () => null,
+    image: async () => null,
+    hasBack: () => !!sp.back,
+    spineEntry: (_, o = {}) => (o.back ? sp.back : sp.front),
+    spine: { acquire: async (entry) => ({ animations: Object.keys(entry.animations || {}).map((name) => ({ name })) }), release() {} },
+  };
+}
+async function op(id, info = {}) {
+  const ctx = fakeViewCtx(fake.P, { assets: store(id), cam });
+  const v = new UnitView(ctx, { id: 1, side: 'ally', kind: 'op', defId: id, spine: id, tier: 5, x: 5, y: 9, maxHp: 2657, dir: 'RIGHT', skillIndex: 1, ...info });
+  await tick(); await tick();
+  assert.ok(v.actor, 'Spine model built');
+  return v;
+}
+const clip = (v) => v.actor.current;
+const frames = (v, n, dt = 1 / 60) => { for (let i = 0; i < n; i++) v.update(dt, cam(), i * dt); };
+const secs = (v, s) => frames(v, Math.round(s * 60));
+
+describe('归溟幽灵鲨\'s 替身 (FORMS doll)', () => {
+  test('the clip set exists in her Front skeleton; the Back one (facing UP) only has Idle_B and Start_2', () => {
+    const f = FORMS[GHOST].doll;
+    const front = assets.chars[GHOST].spine.front.animations, back = assets.chars[GHOST].spine.back.animations;
+    for (const name of [f.change, f.end, f.leave, f.roles.idle, f.roles.die]) assert.ok(name in front, name);
+    assert.equal(f.roles.attack, null, 'the 替身 never attacks (PRTS 特性备注)');
+    assert.equal(f.roles.skill, null);
+    for (const name of ['Idle_B', 'Start_2']) assert.ok(name in back, `Back ${name}`);
+    for (const name of ['Start_B', 'Die_B', 'Die_B_2']) assert.ok(!(name in back), `no Back ${name}`);
+    assert.equal(assets.chars[GHOST].spine.front.anims.idle, 'Idle', 'the manifest keeps the 本体');
+  });
+
+  test('the switch: Start_B, Idle_B (no attack clip), Die_B over its last second, the 本体 back on Start_2 with her own skill clip', async () => {
+    const v = await op(GHOST, { skillIndex: 2 });
+    assert.equal(clip(v), 'Idle');
+    const dur = DOLL_SWITCH + 20;
+    v.setForm('doll', { id: 1, form: 'doll', dur });
+    assert.equal(clip(v), 'Start_B', 'the 替身 fades in');
+    secs(v, 1.1);
+    assert.equal(clip(v), 'Idle_B');
+    v.onAttack(null, 2);
+    assert.equal(clip(v), 'Idle_B', 'no attack clip');
+    secs(v, dur - 1 - 1.1 + 0.05);
+    assert.equal(clip(v), 'Die_B', 'it breaks apart over its last second');
+    secs(v, 0.9);
+    v.setForm(null, { id: 1, form: null });          // the sim's 'swap' fx
+    assert.equal(clip(v), 'Start_2', 'the 本体 comes back');
+    secs(v, 1.1);
+    assert.equal(clip(v), 'Idle');
+    v.setSkill(true);
+    assert.equal(clip(v), 'Skill_3_Begin', 'her equipped skill\'s clips again (S3), not the manifest default');
+    v.die();
+    assert.equal(clip(v), 'Die', 'the 本体\'s death clip');
+  });
+
+  test('knocked out as the 替身: Die_B_2, held through the form reset (\'dollEnd\'); the redeploy is the 本体', async () => {
+    const v = await op(GHOST);
+    v.setForm('doll', { dur: 21 });
+    secs(v, 2);
+    v.die();
+    assert.equal(clip(v), 'Die_B_2', 'the 替身 collapses');
+    v.setForm(null, { form: null });                 // fx 'dollEnd', after the 'die' event
+    assert.equal(clip(v), 'Die_B_2', 'no Start_2 on a knocked-out view');
+    assert.equal(v.form, null);
+    secs(v, 3);
+    v.onDeploy();
+    assert.equal(clip(v), 'Start', 'redeployed as the 本体');
+    secs(v, 1.2);
+    assert.equal(clip(v), 'Idle');
+  });
+
+  test('a view built while she is the 替身 (UnitInfo form) starts on Idle_B; facing UP the Back model shows the 替身 without the switch clips it lacks', async () => {
+    const v = await op(GHOST, { form: 'doll' });
+    assert.equal(clip(v), 'Idle_B');
+    const up = await op(GHOST, { dir: 'UP' });
+    assert.ok(up.entryBack, 'the Back model');
+    up.setForm('doll', { dur: 21 });
+    assert.equal(clip(up), 'Idle_B', 'no Start_B in the Back skeleton: straight to the 替身');
+    secs(up, 21);
+    up.setForm(null, { form: null });
+    assert.equal(clip(up), 'Start_2', 'its Start_2');
+    const turned = await op(GHOST, { form: 'doll' });
+    turned.setDir('UP');
+    await tick(); await tick();
+    assert.ok(turned.entryBack && clip(turned) === 'Idle_B', 'turned UP mid-form: the Back model keeps the 替身');
+  });
+
+  test('the 替身\'s status icon; a late switch fx skips a change clip that would already have ended', async () => {
+    assert.equal(statusIconKey('trait:substitute'), 'doll');
+    assert.ok(STATUS_KEYS.includes('doll'));
+    const v = await op(GHOST);
+    v.setForm('doll', { dur: 21, late: 1.5 });
+    assert.equal(clip(v), 'Idle_B');
+    v.setForm(null, { form: null, late: 2 });
+    assert.equal(clip(v), 'Idle', 'no Start_2 when it would be over');
+  });
+});
+
+test('风丸\'s 替身: Start_B, Idle_B / Attack_B (it attacks), Die_B; the 本体 back on Start', async () => {
+  const anims = assets.chars[KAZEMA].spine.front.animations;
+  for (const name of ['Start_B', 'Idle_B', 'Attack_B', 'Die_B', 'Start']) assert.ok(name in anims, name);
+  const v = await op(KAZEMA);
+  v.setForm('doll', { dur: 21 });
+  assert.equal(clip(v), 'Start_B');
+  secs(v, 1.1);
+  assert.equal(clip(v), 'Idle_B');
+  v.onAttack(null, 2);
+  assert.equal(clip(v), 'Attack_B');
+  secs(v, 3);
+  v.setForm(null, { form: null });
+  assert.equal(clip(v), 'Start');
+  const w = await op(KAZEMA, { form: 'doll' });
+  w.die();
+  assert.equal(clip(w), 'Die_B');
+});
+
+test('sim → view: the real 归溟幽灵鲨\'s lethal hit puts UnitInfo `form` doll (renderInfo keeps it) and its fx carry the forms the view switches on', async () => {
+  const h = makeBattle({ autoFinish: false, timeLimit: 60, defs: { enemies: { enemy_dummy: enemyRec({ key: 'enemy_dummy', hp: 1e9, atk: 0, speed: 0 }) } },
+    units: [{ chessId: 'chess_char_5_13_a', row: 9, col: 5 }], enemies: [{ key: 'enemy_dummy', pos: [9, 6] }] });
+  h.step();
+  const g = h.unit('chess_char_5_13_a');
+  const v = await op(GHOST, renderInfo(unitInfo(g)));
+  const apply = () => { for (const e of h.eventsOf('fx')) if (e[4]?.id === g.id && fxForm(e) !== undefined) v.setForm(fxForm(e), e[4]); h.events.length = 0; };
+  h.b.dealDamage(null, g, { amount: 1e9, type: 'true' });
+  apply();
+  assert.equal(renderInfo(unitInfo(g)).form, 'doll');
+  assert.equal(clip(v), 'Start_B');
+  secs(v, 1.1);
+  h.run(DOLL_SWITCH + 20.05);
+  apply();
+  assert.equal(clip(v), 'Start_2', 'back to the 本体');
+  assert.equal(renderInfo(unitInfo(g)).form, undefined);
+});
+
+// The clip meanings, read from the official skeleton (tools/assets/skel.mjs's parser, @pixi-spine/runtime-3.8): the *_B
+// clips draw only the 替身's own slots (names ending in _T), Start_B and Start_2 fade in, Die_B ends faded out (the 替身
+// gone: the switch back), Die_B_2 keeps it visible (collapsed: a knock-out).
+const SKEL = path.join(ROOT, `public/assets/spine/op/${GHOST}/front/${GHOST}.skel`);
+test('the official skeleton: *_B clips are the 替身, Die_B ends gone, Die_B_2 ends down, Start_2 brings the 本体 back', { skip: !existsSync(SKEL) && 'assets not fetched' }, () => {
+  const require = createRequire(path.join(ROOT, 'package.json'));
+  const r = require('@pixi-spine/runtime-3.8'), B = require('@pixi-spine/base');
+  const att = (n) => new r.RegionAttachment(n);
+  const loader = { newRegionAttachment: (s, n) => att(n), newMeshAttachment: (s, n) => new r.MeshAttachment(n), newBoundingBoxAttachment: (s, n) => new r.BoundingBoxAttachment(n), newPathAttachment: (s, n) => new r.PathAttachment(n), newPointAttachment: (s, n) => new r.PointAttachment(n), newClippingAttachment: (s, n) => new r.ClippingAttachment(n) };
+  const data = new r.SkeletonBinary(loader).readSkeletonData(new Uint8Array(readFileSync(SKEL)));
+  const sk = new r.Skeleton(data);
+  /** Slots drawn (attached, alpha > 0) at time t of clip `name`: { doll, body } counts. */
+  const drawn = (name, t) => {
+    const a = data.findAnimation(name);
+    sk.setToSetupPose();
+    a.apply(sk, 0, Math.min(t, a.duration), false, null, 1, B.MixBlend.setup, B.MixDirection.mixIn);
+    let doll = 0, body = 0;
+    for (const s of sk.slots) if (s.attachment && s.color.a > 0.01) { if (/_T\d*$/.test(s.data.name)) doll++; else body++; }
+    return { doll, body };
+  };
+  for (const name of ['Idle_B', 'Start_B', 'Die_B', 'Die_B_2']) assert.equal(drawn(name, 0.5).body, 0, `${name}: no 本体 slot`);
+  for (const name of ['Idle', 'Start_2', 'Die']) assert.equal(drawn(name, 0.5).doll, 0, `${name}: no 替身 slot`);
+  assert.ok(drawn('Idle_B', 0.5).doll > 30, 'Idle_B draws the 替身');
+  assert.equal(drawn('Start_B', 0).doll, 0, 'Start_B: it fades in');
+  assert.equal(drawn('Die_B', 1).doll, 0, 'Die_B: gone at its end');
+  assert.ok(drawn('Die_B_2', 1).doll > 30, 'Die_B_2: still there, collapsed');
+  assert.equal(drawn('Start_2', 0).body, 0, 'Start_2: the 本体 fades in');
+});